jts icon indicating copy to clipboard operation
jts copied to clipboard

CI Builds and Tests all major versions of Java on Ubuntu and MacOS.

Open carldea opened this issue 3 years ago • 7 comments

The contribution type: enhancement The module being contributed to: jts-build

CI Builds and Tests all major versions of Java (8-15) on Ubuntu and MacOS. The following matrix describes the Java versions and OS platforms.

matrix:
        java: [8, 8.0.192, 11, 11.0.9, 12, 13, 13.0.4, 14.0.2, 15]
        os: [ubuntu-latest, macOS-latest]

carldea avatar Nov 19 '20 03:11 carldea

Not sure about the last check related to the Eclipse Foundation's Contributor Agreement. I signed up and submitted the info.

carldea avatar Nov 19 '20 04:11 carldea

@carldea what email address did you use for the Eclipse Contributor Agreement?

jnh5y avatar Nov 30 '20 15:11 jnh5y

@carldea what email address did you use for the Eclipse Contributor Agreement?

It is carl.dea at gmail.com as opposed to carldea at gmail.com, in GitHub it's run together.

Thank you! Carl

carldea avatar Nov 30 '20 16:11 carldea

@carldea ah, ok, did you sign-off your commits with git commit -s?

Each commit needs to be signed off; I know it is a pain. It may be easier to merge squash and open a new PR.

jnh5y avatar Nov 30 '20 16:11 jnh5y

@dr-jts I am liking the idea of checking out the JTS build on multiple versions of Java. I doubt we'll see anything come up. The checks appear to run relatively quickly. Any feedback on this PR?

jnh5y avatar Nov 30 '20 16:11 jnh5y

@carldea ah, ok, did you sign-off your commits with git commit -s?

No, but will do.

Each commit needs to be signed off; I know it is a pain. It may be easier to merge squash and open a new PR.

Sounds great. Will create another PR.

carldea avatar Nov 30 '20 16:11 carldea

@jnh5y Somehow my Eclipse Foundation account is confused with my carldea vs carl.dea email. I made a PR to replace this one to: https://github.com/locationtech/jts/pull/646

carldea avatar Nov 30 '20 20:11 carldea