Jordan Eldredge comments

Results 370 comments of


                                            Jordan Eldredge

[relay-lsp] Ensure documents are synced before calculating completions

Landed as https://github.com/facebook/relay/commit/2b502883c730aefd9ff37eb6c6074e63731537bc

[relay-lsp] Ensure documents are synced before calculating completions

Thanks again for this excellent PR and your patience!

Fix typo in editor-support.md

ping @tsaiDavid

[relay-compiler] Fix LocalPersister repersist

I think that cleaning up old operations and then deploying would potentially break all users who currently have your site open in a browser and then attempt to navigate since...

Integration with google/oss-fuzz for continuous fuzzing

Thanks for suggesting this. Fuzzing is certainly interesting, and something I've often wished we could make better use of. I'd be curious to learn a bit more: 1. What are...

Integration with google/oss-fuzz for continuous fuzzing

Thanks for the response! Maybe we can start with the bugs you already found and see if it feel like the kind of bug reports that provide value? I'm a...

Integration with google/oss-fuzz for continuous fuzzing

Great! Looking forward to any bugs you're able to uncover and going from there! > would you mind expanding on what you mean by fragility in this context? Mostly that...

feat(compiler): add type declaration with relay config file types

I love this idea, and I've wanted it for some time. I was hopeful that there would be some way to use serde to derive this, but so far I...

feat(compiler): add type declaration with relay config file types

@noghartt > I couldn't find anything that documentate these configurations, any idea where I can find it? Sadly the best source of truth is the Rust crate. Luckily most of...

feat(compiler): add type declaration with relay config file types

Another point: We don't have authoritative docs on this config. As a baseline we should link out to this definition from our docs as a "Here's where you can go...