Safia Abdalla

Results 518 comments of Safia Abdalla

> I think the fundamental right choice here is to modify the ProducesAttribute such that the OnResultExecuting invocation no-ops under certain scenarios since that's the root cause here. @brunolins16 What...

> @halter73 or @captainsafia may remember another time when we made a breaking change to a pubternal type with no public documentation? I don't recall any explicit scenario but it...

We may want to take a look at the code ASP.NET uses for header comparisons ([ref](https://source.dot.net/#Microsoft.Net.Http.Headers/MediaTypeHeaderValue.cs,385)) here. It's used in ASP.NET to validate `Accepts` headers and handle the case-sensitivity rules...

> Yes, it's a shame that's not all in System.Net.Http.Headers.MediaTypeHeaderValue :( Yes, the `Microsoft.Net.Headers` stuff was specifically optimized for server/web scenarios as opposed to the "general purpose" types in `System.Net.Http.Headers`....

Things that we warn on: - `BindAsync` has to be `static` and return a ValueTask of X - This is probably an "Error" level analyzer because request delegate creation will...

~~Test failures are around the broken tests that need investigation. I'll merge this so we can start to get logs to investigate this.~~ Correction: these test failures are new and...

+1 to @martincostello's comments here. I appreciate that it might be challenging to create a repro particularly for issues like this but additional details will be useful in debugging. Are...

> I just hope there will be rich extension points (schema, operation and document filters/processors) so that we can easily provide additional functionality in a nice way... Customizability of the...

> A request from me would be to make it possible for the build process to produce OpenAPI specification files as part of the build output out-of-the-box without me having...

@sander1095 Are you still interested in submitting an API proposal for this one? Also, I believe the new built-in OpenAPI support will support the [DescriptionAttribute](https://learn.microsoft.com/en-us/dotnet/api/system.componentmodel.descriptionattribute?view=net-8.0) on types so we could...