Safia Abdalla

Results 518 comments of Safia Abdalla

> This suggests that the changes are so breaking that it is basically impossible to use Microsoft.OpenApi v2 with ASP.NET Core versions earlier than 10. In general, yes. We can't...

@E-niek Thanks for reporting this issue! I believe this is happening because of the interpolation rules the templating engine uses. I suspect that it removes dashes when it interpolates the...

Yep, that's an option. It does get a little bit interested since we're targeting `netstandard2.0`. The `DynamicallyAccessedMembers` aren't included for that target so you'll have to source include them yourself....

While digging into implementing this, I realized that the `CloneFromCopyConstructor` implementation in the library also presents a challenge for us making it fully trim compatible. I _believe_ that the annotations...

> In the kiota libraries, we've used the first option from the blog post which is using if definitions. This has been successful for us, it just makes the code...

@jkone27 Hey -- sorry I hadn't seen this issue before. 😅 With regard to solving the issues that you referenced in the original bug report, does the guidance that I...

> Looking forward to this feature - thanks for the work on it. Presumably secrets will be stored in plain text in this file? Yep, the generated values that are...

> I would like to have an option to re-prompt, but the default values are fetched from the cache. I'm curious to learn more about what you're thinking about here....

+1 to this. Our native AoT tests in ASP.NET Core caught some issues here (specifically with the `JsonNodeCloneHelper`) that will need to be addressed.

> @captainsafia does the same thing repro when building the `release/8.0` branch? It doesn't appear to repro on release/8.0 for me...