canepat
canepat
I do support merging this PR. I think the current post-check on line length limit has proven more painful than useful. The setup with just `ColumnLimit` set to `0` in...
The proposed changes seem not to fit well into the Silkworm codebase for the reasons already outlined in previous comments by @AndreaLanfranchi. Generally speaking, usage of Silkworm as a library...
> @canepat I'd add a comment to remove stbrume's keccak function when/if @chfast implements a _rolling_ keccak into ethash library. Having two different implementations can be confusing. Good point, @battlmonstr...
> Did you try including `CableBuildInfo` after `project()`? That's my usually fix for this warning. Thanks a lot for this suggestion!
Right, I just compared `History Index` with one line instead of two on the Erigon side.
@chfast Thanks for reporting this! I have some questions: - is this happening during your test using a database primed by Erigon and starting the staged sync loop from Senders...
Let's try to avoid this kind of defensive programming and see if we can instead identify where and why pre-merge rule set can be null in the first place
> Let's try to avoid this kind of defensive programming and see if we can instead identify where and why pre-merge rule set can be null in the first place...
@yperbasis this PR looks good to me at least for preventing null pointer dereference when `pre_merge_rule_set_` is `nullptr` in `MergeRuleSet` (e.g. for Holesky config when checked against empty block), so...
Done in #1878