format: wrap long lines
Manually wrap lines exceeding 120 chars and remove those files from the CI check exceptions.
Note: most of the files (420) didn't have line length violations. This PR fixes 30 files that did have them, and that were easy to fix.
Codecov Report
Merging #736 (63e143d) into master (40b35d0) will decrease coverage by
0.05%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #736 +/- ##
==========================================
- Coverage 75.74% 75.69% -0.06%
==========================================
Files 193 193
Lines 13686 13686
Branches 2185 2185
==========================================
- Hits 10366 10359 -7
- Misses 2409 2414 +5
- Partials 911 913 +2
| Impacted Files | Coverage Δ | |
|---|---|---|
| node/silkworm/rpc/server/server_context_pool.hpp | 100.00% <ø> (ø) |
|
| node/silkworm/rpc/completion_end_point.cpp | 88.37% <0.00%> (-2.33%) |
:arrow_down: |
| core/silkworm/state/in_memory_state.cpp | 90.62% <0.00%> (-1.57%) |
:arrow_down: |
| core/silkworm/state/intra_block_state.cpp | 94.01% <0.00%> (-1.41%) |
:arrow_down: |
| node/silkworm/rpc/server/server_context_pool.cpp | 60.16% <0.00%> (-0.82%) |
:arrow_down: |
| core/silkworm/execution/evm.cpp | 93.61% <0.00%> (+0.23%) |
:arrow_up: |
| node/silkworm/rpc/server/call.hpp | 70.28% <0.00%> (+0.28%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
I do support merging this PR. I think the current post-check on line length limit has proven more painful than useful.
The setup with just ColumnLimit set to 0 in clang-format resulting from this PR is IMHO good enough: in this way the author's attempt to make the code as clear and expressive as possible is keep safe and we can be reasonably certain that none of us will commit very long lines because no one likes to scroll horizontally to read his own code (any gross error can be easily caught during review).