Craig Andrews
Craig Andrews
@magdziarek could you please take a look? Thank you!
I just rebased this again... @novalex thank you for the approval! @teodora-sandu @jonathansantilli @admons @tonidevine1 and anyone else - Is there anything I can do to move this along?
Thanks for this information and for enabling workflows! I'll get right on figuring out and addressing these issues.
@PeterSchafer I've updated this PR - all failures have been fixed. When I run `npm test` now, I get the same result as when I run `npm test` against `master`,...
@PeterSchafer I updated this PR fixing the error in `test/jest/acceptance/config.spec.ts` that the `test_and_release` workflow discovered (`npm test` didn't report this error, so I didn't know about it :shrug:). I also...
> Could you please run `npm run format` before a commit. I'm sorry I forgot to do that :( > The failing tests should be reproducible when running the individual...
In the latest run, I don't understand why the [tap tests](https://app.circleci.com/pipelines/github/snyk/cli/15499/workflows/6428ac3f-bd89-4c43-97b8-a473a2005c57/jobs/166679) failed. Is this something you all are familiar with and can help resolve? Same for the two Windows tests...
@PeterSchafer I figured it out and pushed a commit just now to fix it. The tap tests now run on my system - could you please trigger the workflow and...
I found (and fixed) more race conditions in the tap tests. Can you please run the workflow so can I see if there's anything else wrong? I continue to not...
> **code/snyk (Snyk Internal (Org)) ** — 9 new Code Analysis issues found [Details](https://app.snyk.io/org/snyk-internal-org/project/01792408-a646-43a2-a293-7ee71ed79bea/pr-check/211ac2d5-63a5-4727-a5df-f2bc798d6d4e) >  I have no idea what this means. And the link goes to an access...