Craig Andrews
Craig Andrews
> @candrews Overall looks good, just need to update the `ExecStart` line as I suggested above so that Netdata itself creates the pidfile where systemd expects it to be. >...
@wsnipex can you please review this updated PR? Thank you!
My apologies if this isn't that completely minimal, but it does reproduce the problem and it's really easy to run. Grab this: https://www.integralblue.com/zuul3418.tar.gz And run: `./mvnw spring-boot:run -Dspring-boot.run.profiles=localhost` See the...
The problem is that the request's InputStream is being read multiple times which doesnt' work as Zuul is expecting unless the request is wrapped to specifically implement that behavior. Zuul...
Here's a minimal app: https://www.integralblue.com/zuul3418-2.tar.gz Run `./mvnw spring-boot:run` and see the problem with: `curl -H 'Content-Type: abc/xyz' --data "stuff" http://localhost:8080/TEST.php` You'll see a long delay, and then a stack trace....
Tracing a bit, I noticed that when this occurs, at https://github.com/spring-cloud/spring-cloud-netflix/blob/v2.1.1.RELEASE/spring-cloud-netflix-zuul/src/main/java/org/springframework/cloud/netflix/zuul/filters/pre/Servlet30WrapperFilter.java#L74 `request` is a `org.apache.catalina.connector.RequestFacade` which is not an instance of `HttpServletRequestWrapper`, and `RequestUtils.isDispatcherServletRequest()` returns false, so the method returns...
> If it only happens with `zuul.use-filter=true`, then why use it? I think those reasons are covered in https://github.com/spring-cloud/spring-cloud-netflix/issues/2887 I like the idea of not buffering, don't get me wrong...
> I'd rather turn off trace request body if `zuul.use-filter=true`. That seems reasonable. Should trace request body be off by default always? On a related note, https://github.com/spring-cloud/spring-cloud-netflix/blob/2.0.x/spring-cloud-netflix-zuul/src/main/java/org/springframework/cloud/netflix/zuul/filters/pre/Servlet30WrapperFilter.java has this comment:...
`sqlite3` version 5.0.3 has been released: https://github.com/TryGhost/node-sqlite3/releases/tag/v5.0.3 Can you please now update this project to use it?
A bit off topic... Is the plan to discontinue xmr-stak-{amd, cpu, nvidia} in favor of xmr-stak? If so, is there a guess as to when that may happen?