Craig Andrews

Results 178 comments of Craig Andrews

The "main / Unit Tests" failure appears to be unrelated to the changes made in this PR (please correct me if I'm wrong!)

@aaronlippold or anyone else - can you please take a look at this error? It's very easy to reproduce, so hopefully that helps with resolving it quickly.

It appears this bug is in `@mitre/hdf-converters`, and I found the source for that package at https://github.com/mitre/heimdall2/tree/master/libs/hdf-converters

The only place where `match` is read/called is https://github.com/mitre/heimdall2/blob/v2.6.41/libs/hdf-converters/src/xccdf-results-mapper.ts#L190 so that must be where this error occurs.

> Which SCAP content and profile were you running? That way we can reproduce it on our side because this file looks different than others we have seen. This file...

I think this problem is really an indicator of the converter not implementing major parts of the XCCDF specification correctly, including nested groups. I've submitted an MR which implements that...

> because dynamic linking to glibc is challenging. Why not static link instead to avoid the problem?

@PeterSchafer hopefully this small PR passes all tests and is very easy to merge :)

@PeterSchafer hopefully this small PR passes all tests and is very easy to merge :)