Callum Forrester

Results 57 comments of Callum Forrester

@paulbakker thanks for raising this, I will take a look if I have time. Having only skimmed it, I've had some issues writing tests like this in the past because...

I'm not sure given how different graphql-ws and graphql-ws-next have become. Would the existing tests cover backwards-compatibility?

Also there is currently ``` install_requires = graphql-core==2.* ``` Which might be difficult

Another issue, adding a dependency on `graphql-core>=3` conflicts with a lot of test dependencies (see below), so they would presumably have to be updated and tested. ``` ERROR: pip's dependency...

I originally would have gone for 3 but @untzag makes a good point so I will vote 2.

Great, thanks! Will un-draft this after #1672 gets in then

It's fastforward works, just leads to zero changes, will close as obsolete to #1672

This looks like an interesting idea! Will definitely decrease the likelihood of divergence between different facilities. I have a few thoughts but I'm not 100% about them so welcome discussion....

I think I would be interested in all the use cases you list, @danielballan. But, as you say, they add complexity so perhaps they belong in another module. That's potentially...

Reviewers: @tacaswell @callumforrester