graphql-ws-next

[callumforrester]

trafficstars

I have forked graphql-ws-next (fork) and made changes to make it compatible with graphql-core v3. Would there be any interest in integrating these chagnes into graphql-ws or are the two totally split now?

[SmileyChris]

If we can integrate it then that'd be great! Best case would be we can keep backwards compatibility -- do you think that's possible?

On Fri, 26 Nov 2021 at 23:54, Callum Forrester @.***> wrote:

I have forked graphql-ws-next (fork https://github.com/callumforrester/graphql-ws-next) and made changes to make it compatible with graphql-core v3. Would there be any interest in integrating these chagnes into graphql-ws or are the two totally split now?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/graphql-python/graphql-ws/issues/90, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA227YRMKQ7J3PXDFQKYX3UN5RNTANCNFSM5I2MFEPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[callumforrester]

I'm not sure given how different graphql-ws and graphql-ws-next have become. Would the existing tests cover backwards-compatibility?

[callumforrester]

Also there is currently

install_requires =
    graphql-core==2.*

Which might be difficult

[callumforrester]

Another issue, adding a dependency on graphql-core>=3 conflicts with a lot of test dependencies (see below), so they would presumably have to be updated and tested.

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
graphql-relay 2.0.1 requires graphql-core<3,>=2.2, but you have graphql-core 3.1.6 which is incompatible.
graphene 2.1.9 requires graphql-core<3,>=2.1, but you have graphql-core 3.1.6 which is incompatible.
graphene-django 2.15.0 requires graphql-core<3,>=2.1.0, but you have graphql-core 3.1.6 which is incompatible.

Backwards-compatibility is not looking promising at this point.