Cesar Lizarraga
Cesar Lizarraga
So these are, it seems, Ray only environment variables: https://github.com/ray-project/kuberay/pull/266/files#diff-e47b74595d2e73c27d9519ea8a79afc13d38a2bfa2da5e196756ca6e89037d27R2-R5 So that's what those two set, whereas, the others are for the actual k8s request. If k8s receives a request/limit...
@ecm200, I've simplified it hopefully if you don't mind taking a look.
@ecm200, so the `ray.head.num_cpus` is used here for the Ray Cluster: https://github.com/ray-project/kuberay/blob/0ae90b6b3f89b2c988af40e06083649811c61ac6/helm-chart/ray-cluster/templates/_ray-cluster.tpl ``` - name: CPU_REQUEST value: {{ .Values.ray.head.num_cpus }} - name: CPU_LIMITS value: {{ .Values.ray.head.num_cpus }} ``` and here...
(1) I can definitely figure out if the default configuration can be the same one as generated before maybe with some additions but some if statements can handle that. (2)...
I've made this PR to add environment variables using Click's built-in mechanism for the index-url flag. https://github.com/aboutcode-org/python-inspector/pull/187 This doesn't solve everything but it's a relatively easy built-in start.
Oh I understand, however, given that Click is being used for CLI commands, I think it's best to start there and then go from your draft PR. I still think...
We can certainly attempt to make sure that later is now. One can still gather all the settings in one place and then pass them along. In this case, Click...
I believe I've just rebased and added my signature.
Alright, I'll try again. Not entirely sure how to add it to the PR description though
All commits should be signed off now. @pombredanne @TG1999