python-inspector icon indicating copy to clipboard operation
python-inspector copied to clipboard

Fix 180: Add environment variables to Click CLI options

Open calizarr opened this issue 1 year ago • 6 comments

This will add environment variables as extra options for the index-url flag. Click will split on whitespace for multiple values by default.

Added a possibly unnecessary test to make sure that flags override environment variables.

Signed-off-by: Cesar Lizarraga [email protected]

calizarr avatar Aug 13 '24 16:08 calizarr

I believe I've just rebased and added my signature.

calizarr avatar Aug 15 '24 17:08 calizarr

@calizarr not all the commits have the sign-off, neither the PR description have it

TG1999 avatar Aug 15 '24 18:08 TG1999

Alright, I'll try again. Not entirely sure how to add it to the PR description though

calizarr avatar Aug 15 '24 19:08 calizarr

Something like this

Signed-off-by: Name <email>

in the end of PR description

TG1999 avatar Aug 15 '24 19:08 TG1999

All commits should be signed off now. @pombredanne @TG1999

calizarr avatar Aug 26 '24 19:08 calizarr

@pombredanne what is missing from this PR to get it merged? We also need #180 fixed, and I would like to avoid working around it in ORT.

MarcelBochtler avatar Mar 10 '25 16:03 MarcelBochtler