Caleb Sander

Performance improvements and fixed a bug in fromByteArray() when extra bytes are negative

4

Performance improvements: - Pre-allocating arrays in `encodeChunk()` and `fromByteArray()` - Removing unnecessary operations, e.g. increments of a variable that is never used again - Using bitwise operators (e.g. `& 3`...

Is this sugared syntax really necessary?

3

With ES2015 array destructuring, I find that `let [lastItem] = arr.slice(-1)` is a nice way to access the last item. It is hard to make a mistake with this syntax,...

Carry only single word in multiplication

1

The carry from a multiply or a multiply-accumulate is a single word, so update the functions to clarify that. Use a temporary double word for the computation. And rename "acc"...

alloc: implement FromIterator for Box<str>

9

`Box` implements `FromIterator` using `Vec` + `into_boxed_slice()`. Add analogous `FromIterator` implementations for `Box` matching the current implementations for `String`. Remove the `Global` allocator requirement for `FromIterator` too. ACP: https://github.com/rust-lang/libs-team/issues/196

[Suggestion] Channel Column Improvements

2

A couple things: 1. The channel bar has an awkward-looking column towards the bottom (two rows away from the last row of videos, I have found). Could be fixed by...

- [ ] Arithmetic operations with constants (e.g. `(i32.add x (i32.const 1))` - [ ] Local arithmetic updates with constants (e.g. `(set_local x (i32.add (get_local x) (i32.const 1)))`) - [...

- [ ] Guarded memory accesses - [ ] Division by 0