Caleb White comments

Results 415 comments of


                                            Caleb White

`model-property` type issue

No I'm saying that we might can update the existing type

`model-property` type issue

I'd like to know what Ondre thinks....maybe consider opening an issue at PHPStan to see what he thinks is the best course of action before working on a PR for...

`model-property` type issue

> We just simply need to check for * constant string in the method and act accordingly. Some other methods might need to be adjusted too. @canvural, there are methods...

PHPStan not resolving CastsAttributes generics

Note that this won't be necessary once https://github.com/larastan/larastan/pull/2197 is merged

PHPStan not resolving CastsAttributes generics

@szepeviktor, no that method should be `protected`---the public api is `getCasts()`

PHPStan not resolving CastsAttributes generics

yes, the parent method is `protected` https://github.com/laravel/framework/blob/48bc5ee333a868b49138bad1fca37bdc071f409b/src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php#L1678-L1686

fix: mark macro methods as static only if the closure is static

Hi @Andyuu, you can fix this error by making the closure static since you don't access `$this` inside the closure ```php /** @phpstan-ignore argument.staticClosure (always accessed statically) */ Rule::macro('dateTime', static...

fix: mark macro methods as static only if the closure is static

Make sure you clear the cache after applying fix (`phpstan clear-result-cache`)

Collection `partition()` incorrectly reports possible null return

What is the type of `$model->items` and what is the type of the partition before you split it?

Model id mis-identified as an int

If the model is using the HasUuids trait, then this is fixed by #2197