Caleb White
Caleb White
Personally, I'd like to see two optional rules, for increasing levels of strictness: 1. `NoModelForwardingToBuilder`: this would prevent all methods like `$model->first()`, but still allow methods like `Model::first()` 2. `NoModelStaticForwardingToBuilder`:...
> Do we want to enable the other one by default then? No, generally when adding new rules they should be disabled by default or you will get complaints by...
These rules should also be documented under `docs/rules.md`
> Feel free to edit the rules.md docs as needed. I'm not a maintainer here or I would :upside_down_face:
> @calebdw should I close my PR and you continue on your? No, you should leave this one open :)
I just enabled the first rule in my work repo and fixed some hidden bugs!!
@Smurrlawa, please see the following fix that I needed on my fork: https://github.com/calebdw/larastan/commit/bd469576769d80c26330979d94d838e66dffb1d3 These changes need to be incorporated into this PR
I tried setting symlinks to true and reindexing and that didn't work. Maybe the issue is that phpactor is creating a new workspace in the module because that has a...
After I manually attach the root client to the buffer it is able to correctly find all the symbols...so I guess I need to figure out how to stop neovim...
Ah nice!! I didn't realize that the list of root markers was a priority list. It looks like this worked!!! ```lua { -- ... root_markers = { { '.phpactor.json', '.phpactor.yml'...