Caleb White

Results 416 comments of Caleb White

@ondrejmirtes, @canvural, sorry it took so long to address these comments---just been busy with personal life but hoping to move this forward now :pray:

Hmmm, well I'm not actually installing phpactor using composer so that would never be executed. Typically the json schema is just located in the git repo or is just available...

You need to duplicate the casts in the `@return array` on the `casts` method, or wait until #2197 is merged which does away with that requirement

@smares, what does your model look like?

Your `casts` method needs to be the following (or just use the `$casts` property instead, or wait for #2197 to be merged): ```php /** * Get the attributes that should...

There was a new release, so please update and see if this is still an issue

It looks like the variable is not brought into the local symbol table until it's been used: https://3v4l.org/q9mpg

I'm not sure I really care for yet another custom type like `model-property-or-wildcard`. I think this issue could be moved to the PHPStan repo to better handle custom types in...

> This makes the model-property type useless, since the only way to clear those errors is to disable checkModelProperties. You can also just locally ignore the special cases like the...

You could add another parameter to the `model-property` type to handle the wildcard--- it needs to have a default value of false but that would allow you to have ```php...