Cade Mirchandani
Cade Mirchandani
I agree tests are needed. @Jakob37 mentioned they can help with tests for this, and we can setup some actions to run them. @Jakob37 could you possibly provide a small...
Thank you for putting those datasets together and effort testing @Jakob37! I've always understood that bed coordinates should be 0 based and half open. I'm also going on vacation, but...
> Aha, then I learned something. It looks like you are right. I'll update the range coordinates above then. 0 vs 1 based genomic coordinates is the most annoying problem...
Hi @Jakob37 and @northwestwitch, will try to work on this later this week!
There is some weird double counting happening in `feed_range`. Added a print statement in `feed_range` to see whats happening: ```rust fn feed_range(&mut self, left: u32, right: u32, value: &mut Once)...
Thanks for taking a look at this @Jakob37 and @northwestwitch. I too ended up at the `scan_partition_impl` closure in my debugging. I think the issue stems from `last_right` being set...
My workaround seems to break the test in `d4tools/test/test-results/stat/region-stat`. Still trying to wrap my head around it. In the test, none of the bed regions are overlapping which seems to...
Wow, awesome @Jakob37! I was planning on picking up where I left off on this tomorrow morning, but it looks like you've figured it out! And I think this is...
Great. I'll do some testing as well. Will you make a new PR with your fix? Then if all is good @brentp can merge that and then this one.
@Jakob37 great! I'll try to get this done asap.