Cade Mirchandani
Cade Mirchandani
bump @johanneskoester
> > @johanneskoester Sounds good. One more thing, regarding built in logger plugins, how should that be handled? I was thinking of adding a HTTP and JSON logger as builtin...
@johanneskoester let me know what you would like to see before merging this. I had put this on the backburner last month, but will have time to work on this...
Added some of the nitpicks, dependency to setup cfg, and updated the output settings type.
> **Actionable comments posted: 0** > > 🧹 Nitpick comments (2) > > snakemake/logging.py (2)> `424-433`: **Simplify filter logic for better readability.** > > > The filter logic can be...
> > > **Actionable comments posted: 0** > > > 🧹 Nitpick comments (2) > > > > snakemake/logging.py (2)> `424-433`: **Simplify filter logic for better readability.** > > >...
I've added some more to this PR. 1. `--quiet` now accepts `reason` which will suppress reason info in the logs (see #2552, #2725). 2. The `LoggerManager` class has been cleaned...
Hi @johanneskoester - Unfortunately I can't seem to exactly replicate the environment that the actions run in, which has made troubleshooting a bit of pain, however, I've got some more...
@johanneskoester all tests pass, would appreciate your review. There is still room for improvement, particularly in where and what we log (handful of empty log messages, could use logging on...
Pushed some more changes here. @johanneskoester I added an enum `LogEvent` to replace the `level` field in the extra dict and renamed it to `event`. I chose "event" because it...