magic-modules
magic-modules copied to clipboard
Update sql_instance_iam_condition.tf.erb
This change is based on feedback that Akhil provided for the documentation.
If this PR is for Terraform, I acknowledge that I have:
- [ ] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
- [ ] Generated Terraform, and ran
make test
andmake lint
to ensure it passes unit and linter tests. - [ ] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
- [ ] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
- [ ] Read the Release Notes Guide before writing my release note below.
Release Note Template for Downstream PRs (will be copied)
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
For more information, open the CLA check for this pull request.
Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:
```release-note:TYPE
Release note
```
Hello! I am a robot who works on Magic Modules PRs.
I've detected that you're a community contributor. @shuyama1, a repository maintainer, has been assigned to assist you and help review your changes.
:question: First time contributing? Click here for more details
Your assigned reviewer will help review your code by:
- Ensuring it's backwards compatible, covers common error cases, etc.
- Summarizing the change into a user-facing changelog note.
- Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.
If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.
Diff report:
Terraform GA: Diff ( 3 files changed, 8 insertions(+), 8 deletions(-)) Terraform Beta: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF Cloud Doc Samples: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Tests analytics
Total tests: 2019
Passed tests 1792
Skipped tests: 226
Failed tests: 1
Action taken
Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample
Tests failed during RECORDING mode:
TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample
[view]
Please fix these to complete your PR View the build log or the debug log for each test
Hi @rlv2022, not sure if this is still a relevant change. MM no longer supports CGC samples. I believe the "terraform-on-cgc" internal documentation has just been updated with the new workflow, but essentially you'll be making PR's against https://github.com/terraform-google-modules/terraform-docs-samples directly