Christian

Enum it is then. I'll refractor it by the end of this week. Thanks @Xuanwo @liurenjie1024!

@Xuanwo, @liurenjie1024 ready for another round. Ditched both the trait and the enum. Bare with me: As already mentioned earlier, the enum or the trait were just a vehicle to...

CC @Fokko , @nastra , @Xuanwo

This is not so much about this specific use case - which I also don't care about much either, but about having two different representations for the same entity. Took...

I am not so sure about the closed set. Currently there is a massive amount of TableProperties in Java (https://iceberg.apache.org/javadoc/1.6.1/constant-values.html, search for TableProperties) and we only have a small set...

@sungwy in my comment as well as in the catalog I am using "adls.sas-token" which is exactly what Java and Spark expect: https://github.com/apache/iceberg/blob/4873b4b7534de0bcda2e1e0366ffcf83943dc906/azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java#L33 . We can easily send both from...

@sungwy sorry for the late reply, I overlooked this. Looking good now :) - Thanks!

ADLS Gen2 behaves differently. Even without a trailing slash siblings are not deleted. I think we should at least have consistent behavior, I would opt for the one described above....

@Xuanwo I would slightly tend to only remove "abc" in your example, because its the safe default. My main point is however that behavior should be consistent across storages. GCS...

I think if a client calls `remove_all(table.location)`, this should work and be safe. So I would argue we should treat the input always as a directory / append a path.