Christian

Results 72 comments of Christian

@ZENOTME one feature I did not implement yet is respecting "version.history.num-entries" as mentioned in the [View Spec](https://iceberg.apache.org/view-spec/#view-metadata). I noticed that the table implementation also doesn't implement it. I don't think...

@Fokko thats is a hard topic. The idealist in me would like to eventually see something like substrait beeing used. Adoption of the project is very slow across engines though....

@Fokko from my side this is good to merge - types are complete and tests are passing.

@Fokko @ZENOTME are there any points open from your side that prevent us to merge the View Spec? If so, please let me know :)

@nastra, @Fokko during testing we found a Problem with the "default-namespace". I am hoping for some insights from your side: According to the iceberg view spec, "default-namespace" is required: https://iceberg.apache.org/view-spec/#versions....

@nastra I hope I addressed all your issues regarding functionality. If you are happy with the implementations, feel free to close our discussions :). @ZENOTME it would now be great...

@nastra just following up on my last comment - could you close our discussion where you agree with my fix? @liurenjie1024 could you maybe have a look at the rust...

Rebased on current master

Independant on how the the actual loader functions work, I believe implementing the Iceberg Spec for `Views` is a good idea. As I have needed the structs from the spec,...

Sure - PR is coming. I'll have some more tricky great catches tomorrow ;)