Christian
Christian
Thanks for your Feedback @liurenjie1024. This isn't really a refactoring of the builder, it's more a complete rewrite. The old builder allowed to create corrupt metadata in various ways. Splitting...
@liurenjie1024 I tried to cut a few things out - but not along the lines of `TalbeUpdate`. I hope that's OK? 1. https://github.com/apache/iceberg-rust/pull/611 2. https://github.com/apache/iceberg-rust/pull/612 3. https://github.com/apache/iceberg-rust/pull/613 4. https://github.com/apache/iceberg-rust/pull/614 5....
@liurenjie1024 thanks for the Feedback! > > My first point of the opening statement: Do we re-write our SortOrder and add the schema to PartitionSpec so that we can match...
> > My second point from the opening statement: How do we handle new_last_column_id > > I've took a look at the comments of these two prs: https://github.com/apache/iceberg/pull/6701 https://github.com/apache/iceberg/pull/7445 >...
@Xuanwo, @liurenjie1024 this PR is ready for another round of review. It's now rebased on the 6 PRs we merged during the last months. The core logic is ~1100 lines...
@liurenjie1024 for `set_branch_snapshot` I was missing an easy way to determine the type of a ref. I introduced an enum `ReferenceType`, but if you don't like that, I can also...
> @liurenjie1024 for `set_branch_snapshot` I was missing an easy way to determine the type of a ref. I introduced an enum `ReferenceType`, but if you don't like that, I can...
Introducing `SchemalessPartitionSpec` might be our way to avoid https://github.com/apache/iceberg/issues/4563.
@liurenjie1024 , @Xuanwo could you maybe have a brief first look if this is going in a good direction? Then I could start refactoring the Builder.
Hey @liurenjie1024 , thanks for giving it a look! Regarding 1) they are not identical (see also my argument from the start. FieldId is optional for unbound spec, but it...