bytefactory73
bytefactory73
i fixed that with my pull request. i have no idea to to attach that to my submit.
my fix skips all non-cpp files. also header files. i thought the same that it would be cool to have .h optimization. but i'm not sure if the api allows...
some one created a test where a zip file is expected to fail. of course this would be obsolete now. zip support enabled this and 200 is returned instead of...
> some one created a test where a zip file is expected to fail. of course this would be obsolete now. > > zip support enabled this and 200 is...
> Thanks. Need to think about your approach here, a couple things Im not sure of with the SkipImportException and frankly Im not sure if a parser kicking of `consume_file`...
> > i'm not familar with the design of the software. this was the one approach which i thought that it could work because it uses the "plugin/registration" system without...
i rewrote the code to move the logic out of the parser into the consume.py i couldn't find a better way yet. my goal was to: - let the zip...
> 3. Testing, of course. And as mentioned, you should alter the old .zip test to still do the same thing it currently does (otherwise you are removing a test...
> 1. Get rid of the zip parser completely, it's just a vestige of the old implementation and makes the whole thing much harder to understand. There is definitely another...
> > pdf cannot be used anymore since it‘s now a supported type. > > Indeed, so the test should still test an _unsupported_ type. > > > i think...