bytefactory73
bytefactory73
> I’m going to hold off on merging (or really reviewing) this until there is more support for the feature request. I am not in love with the added complexity...
> Why is the diff so much larger than the previous version of this PR? Please don’t rearrange the rest of the consumer code for no reason. I tried to...
btw. if you take a real diff tool to see the changes in consumer.py then you will notice that it's only the indentation that changes. github is not very good...
i reverted the code for non zip related parts
> > i reverted the code for non zip related parts > > Thanks. There is still a lot of new code here vs #10274 , all of the sort...
i removed the special name handling.
> Thanks. Before we look at this for real please address the coverage, I think it should be 100% for a small patch like this, and important we keep changes...
> Coverage is the idea of writing tests that “cover” the code you wrote. Tests are meant to be kinda like “proof” that it does what you say it does,...