Jean Boussier comments

Results 529 comments of


                                            Jean Boussier

If a job fails due to an error, it is discarded, and don't re-raise.

I think we can close?

Enhance bin/dev to run server in foreground AND still use foreman

I think we could handle this by spawning foreman from the dev server process. This can be independent of the server used in development, and allow to redirect foreman output...

Certain ActiveRecord queries are not using parameterized queries

> is this something that is considered out of scope for Rails/ActiveRecord? Kind of. Parameterized queries have been implemented mostly to allow preparing statements, not for trimming server logs, hence...

Support second-level precision for `assert_enqueued_with`

The CI failure is legit. Also please squash your commits.

Shink RClass when it is known they can't be namespaced

Good catch. > they either need to also be made namespaceable, I think that is the way, but I can probably handle that. When creating a singleton class I can...

Shink RClass when it is known they can't be namespaced

I made it so that metaclasses created from a namespaceable class are also namespaceable. (I didn't fix https://bugs.ruby-lang.org/issues/21343 though.)

Multiple SSL certificates - certificate rotation

> Is there a way to perform certificate rotation currently with the gem? I suppose you can try connecting with one certificate, and if you get an error, connect with...

io_buffer.c: Allow copies between overlapping buffers with #copy and #set_string

I believe @ioquatix maintains this class, so I added him as reviewer so he has a chance to chime in if necessary, but if not I'll merge tomorrow.

Adding support for Redis 7.0 commands

As you can see in all linked PRs, commands are added whenever someone who needs it makes a PR for it. Adding support for a command is pretty trivial so...

Escape HTML Entities

So this is a feature I considered in the past, to help speedup `ActiveSupport::JSON::Encoding`, which currently does a big `gsub`: https://github.com/rails/rails/blob/f575fca24a72cf0631c59ed797c575392fbbc527/activesupport/lib/active_support/json/encoding.rb#L54-L60 I suppose that's what `Oj.dump(value, mode: :rails)` tries to...