Bartlomiej Plotka

Results 932 comments of Bartlomiej Plotka

Still needed, no progress on this yet. Help wanted! @mkabischev did something promising! https://github.com/thanos-io/thanos/issues/2321#issuecomment-603765739

Tracing is done, but we might want to log more on debug.

This was merged: https://github.com/grpc-ecosystem/go-grpc-middleware/pull/223 so we might want to think about upgrading middleware and getting this in. However the current version is not fully correct on middleware sides, the `v2`...

Well not blocker, just some dependency we need to work on. I am maintainer on grpc middleware, as well, so yea we might want to push something forward. TBH the...

Queries are in Jeager for sure. We use that fact every day. (: Will add clear acceptance criteria to this issue, good point (: On Fri, 1 May 2020 at...

@yashrsharma44 is on it

Partially. We discussed this with @krajorama and long term we want to experiment with generics/interface instead of `h, fh`: ``` // TODO(bwplotka): We plan to experiment on using generics for...

> what if you start two lazygit instances in the same repo? Happens for me occasionally; we'd have to make sure that they don't overwrite each other's log. Yes, with...

cc @bboreham - want to check it? You might have some thoughts. (:

Nice! Technically it feels commit should be part of `scrape_duration_seconds` as it's an important step that actually persist samples on disk (WAL). We already add some appending latency (e.g. through...