Bartlomiej Plotka

icon indicating a website link https://bwplotka.dev/

icon company Google icon location London, UK icon location Fascinated by challenging engineering problems & distributed systems. Go & OSS fan. Prometheus maintainer, Thanos co-author. CNCF TAG Observability Tech Lead.

Results 932 comments of Bartlomiej Plotka

Implement filter for remote write

Hm, something went wrong with https://github.com/prometheus/client_golang/pull/1864 (it was old PR, merged now) -- if you could fix it on the way it would epic, otherwise will fix in the incoming...

emptyLabels used in instrument_server.go cause concurrent map writes

Hello from the Bug Bash! Looks still important, keeping it open.

Timer helpers

Thanks for this proposal! BTW: Likely here or Slack is a better place for those discussions. I have some questions around benefit vs cons (code to maintain, 2 ways of...

Timer helpers

Great discussion! Just curious, who is "we" you are referring to in this PR? (: > ``` > type Handler2 struct { > reqDuration *TimerCounter > } > > func...

Timer helpers

Also for your HTTP request example, there are better ways than timer, `promhttp` gives you robust handlers. Then if we choose 2A, I don't see the need for *Vec flavor...

This change enables setting min and max values for gauges. It prevent…

Hi! Thanks for proposing! So do I understand this right, that you want to ensure some gauge boundaries, for easier later query use, because implementing reliable sub/add operation is not...

This change enables setting min and max values for gauges. It prevent…

For general instrumentation logic, sounds like you really need stateful medium to remember the number of old logins OR you search for some periodic session logs OR you use counters....

om2: MetricFamilyName is MetricName

I am bit surprised but I couldn't find any special rule for those suffixes in the ABNF to change... also tests passes despite me adding suffixes to MF names. Something...

Support the SetWriteDeadline and SetReadDeadline interfaces

Still todo

docs(clientlibs): Add Prometheus kotlin client library

Thanks 👋🏽 and great job for writing a new SDK! 💪🏽 It looks solid. We don't have a policy on the adoption/quality bar for community exporters yet (to include them...