Bill Engels

Results 27 comments of Bill Engels

Ah yup, added --- View entire conversation on ReviewNB

Yup it does. plot_gp_dist really needs to be updated to work with InferenceData objects. Really like az.extract, though I have to brag that I'm pretty fast now at typing idata.posterior.thing.stack(sample=['chain',...

Hey so sorry I missed this, yes I definitely can. As far as I know everything in it is up to date.

I think when pre-commit or black or whatever else makes changes, you just need to `git add` and `git commit` the changed files it changed. `git checkout` I think will...

Took another crack at it, basically made the docstring more minimal and added an example as per your suggestion @ricardoV94. Would it be nice to also have the syntax allow...

One last question, if you don't mind, I can't seem to figure out why [pre-commit isn't happy](https://github.com/pymc-devs/pymc/actions/runs/3131146737/jobs/5082180041#step:4:106). Since this PR just changes docstrings, what's it saying about numpy, positional arguments?

Weird! The K-means initialization hasn't changed in a long time. Maybe a change upstream. Will take a look

Thanks for reviewing @OriolAbril -- Yup you're right there's a ways to go. Hey @conorhassan do you mind [converting it to draft?](https://stackoverflow.com/questions/55070723/how-do-i-change-from-a-pr-to-a-draft-pr-at-github). That's my bad I forgot to mention that...

Is pre-commit correcting some spelling issues? What I see in pre-commit isnt in the PR diff

This would be nice to do. It would allow `pm.sample_posterior_predictive` to work correctly over the original input domain `X` (so, to see the fit) without the need to append an...