pymc-examples icon indicating copy to clipboard operation
pymc-examples copied to clipboard

Conditional autoregressive prior example notebook

Open conorhassan opened this issue 1 year ago • 2 comments

Here is a new notebook using pm.CAR distribution. The linked issue is #405.

The notebook uses parts of the code from the already existing CAR notebook example, but is updated to v4, uses pm.CAR and has a few other bits and pieces.

Checklist:

  • [x] Notebook follows style guide https://docs.pymc.io/en/latest/contributing/jupyter_style.html
  • [x] PR description contains a link to the relevant issue: a tracker one for existing notebooks or a proposal one for new notebooks
  • [ ] Check the notebook is not excluded from any pre-commit check: https://github.com/pymc-devs/pymc-examples/blob/main/.pre-commit-config.yaml

I am getting jupytext pre-commit errors and am unsure how to fix them.

conorhassan avatar Sep 09 '22 00:09 conorhassan

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Thanks for reviewing @OriolAbril -- Yup you're right there's a ways to go. Hey @conorhassan do you mind converting it to draft?. That's my bad I forgot to mention that yesterday. If it's in draft it pretty much just signals "no intent to merge yet, just putting this up publicly so it's visible and any feedback is welcome". Not in draft signals "Pretty much ready, any last changes that I could/should make before merging this?"

Quick Q though @OriolAbril, if you don't mind. This is a follow up from #405. Do you know why pre-commit is failing? We fixed the ther issue, but something is still amiss. We didn't have much luck yesterday.

We tried commiting the changes seen in the current diff made by jupytext, but iirc something else fails, we regenerate the myst file, and we ended up here again.

If it's not super obvious, I'll be able to check out the PR and give it another try in a few days.

bwengals avatar Sep 10 '22 00:09 bwengals

Just saw I missed the notification for this PR. I don't know why it is complaining. I would try rebasing and seeing how it goes. Otherwise I can try to check out this PR and take a look

OriolAbril avatar Oct 27 '22 11:10 OriolAbril

Is pre-commit correcting some spelling issues? What I see in pre-commit isnt in the PR diff

bwengals avatar Nov 07 '22 23:11 bwengals

Is pre-commit correcting some spelling issues?

yes, one of the pre-commit jobs is a spellcheck

OriolAbril avatar Nov 09 '22 23:11 OriolAbril

I just wanted to say I'd like to pick the work on this and make sure this gets merged. I'll dig in tomorrow morning and hopefully send a PR then.

daniel-saunders-phil avatar May 23 '23 00:05 daniel-saunders-phil

#547 replaces this pr - should be safe to close at any point.

daniel-saunders-phil avatar Jun 17 '23 23:06 daniel-saunders-phil