Brendon Votteler

Use chain metadata for more unit tests

1

Some unit test register types manually. It would be better to get them dynamically. See [this example](https://github.com/interlay/interbtc-api/blob/d987b57b73aa1a008037dab6d653f302ba560584/test/unit/parachain/asset-registry.test.ts#L36-L50) in asset-registry tests. And this relevant discussion on a previous PR: https://github.com/interlay/interbtc-api/pull/429#discussion_r910898489 So,...

Fix test “should cancel a redeem request”

1

The skipped test in `redeem.test.ts` needs a rewrite: We want to ban one vault (one specific collateral currency), and check that the other currency for a vault with the same...

We introduced a bug when refactoring some work as getting staked rewards called the incorrect palette’s withdrawRewards() function (ie. `escrow` rather than `escrowAnnuity`). The method making the call: [EscrowAPI.buildWithdrawRewardsExtrinsic()](https://github.com/interlay/interbtc-api/blob/d987b57b73aa1a008037dab6d653f302ba560584/src/parachain/escrow.ts#L179) Add...

Include ID of foreign asset not found when rejecting

1

The rejection message in `DefaultAssetRegistryAPI.getForeignAsset(...)` should include the id. https://github.com/interlay/interbtc-api/blob/d987b57b73aa1a008037dab6d653f302ba560584/src/parachain/asset-registry.ts#L99

We should be able to refactor some of our integration tests to use dryRun where the tests do not rely on a changed state for follow up actions. The approach...

Investigate how much effort it takes to add tests for code snippets in our readmes to be tested using this library: https://github.com/bbc/typescript-docs-verifier The goal is to be able to fail...

We want the returned errors from the API to be easier to parse than just having a (hard-coded) string. It would also be more useful if the error itself could...

1) Move ATOMIC_UNIT constant to [monetary](https://github.com/interlay/monetary) See PR comment: [https://github.com/interlay/interbtc-api/pull/435#pullrequestreview-1049359039](https://github.com/interlay/interbtc-api/pull/435#pullrequestreview-1049359039) 2) Recreate `atomicToBaseAmount()` in monetary See PR comment: [https://github.com/interlay/interbtc-api/pull/435#pullrequestreview-1049295459](https://github.com/interlay/interbtc-api/pull/435#pullrequestreview-1049295459) 3) Recreate static method `newMonetaryAmount()` (in `src/util/currency.ts`) in monetary-js 4) Mark...

A recent change has been made to this function to return a rejected promise if globalStake is 0 (see https://github.com/interlay/interbtc-api/pull/414/) We still want an additional unit test for the rejection...

`OracleApi.getOnlineTimeout()` currently returns a `number` which can lead to errors for particularly big values - which can be set in test environments to avoid oracle values from timing out. Change...