Evaldas Buinauskas

@iamazy totally! Try submitting changes in smaller batches if possible, they'll be easier to review. Let me know if you have some questions, I'll be glad to answer them. Thank...

@iamazy that's excellent!

@iamazy I just want to appreciate and thank you for all the work you've put into implementing aggregations/queries for this project. You're doing an amazing job, thank you!

First of all, thank you for contributing! You're really on a good track, I've left some comments and suggestions.

Things look pretty sharp, I believe you got the logic nailed, so these are the common changes across all of the queries: - Make sure to implement `ShouldSkip` correctly for...

FYI this will impact your changes https://github.com/vinted/elasticsearch-dsl-rs/pull/160 slightly.

What @Razzeee has said. Default Git config will always normalize line endings in Windows. I've had no issues so far with this. :)

I figured this is already obsolete and no longer in progress, so I've taken your work and implemented span queries myself in https://github.com/vinted/elasticsearch-dsl-rs/pull/207. Thank you 🙇🏻

@dean-shaff cool, so make sure to rebase on latest first and then submit the change if possible. There were some breaking changes in Rust 1.73.0 that required updating the code....

@dean-shaff sorry, I've been away and could only come back to this now. Could you split this PR into two? One for collapse, the other one for includes/excludes in terms...