elasticsearch-dsl-rs icon indicating copy to clipboard operation
elasticsearch-dsl-rs copied to clipboard

Published 20 hours ago • verified publisher icon vinted

Add include and exclude to terms aggregation

Open dean-shaff opened this issue 1 year ago • 4 comments

Add include and exclude parameters to terms aggregation: https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-bucket-terms-aggregation.html#_filtering_values_4

dean-shaff avatar Oct 31 '23 15:10 dean-shaff

There is no rush whatsoever!

dean-shaff avatar Nov 09 '23 07:11 dean-shaff

@dean-shaff cool, so make sure to rebase on latest first and then submit the change if possible. There were some breaking changes in Rust 1.73.0 that required updating the code. Otherwise, CI tests would fail.

buinauskas avatar Nov 09 '23 07:11 buinauskas

@dean-shaff sorry, I've been away and could only come back to this now. Could you split this PR into two? One for collapse, the other one for includes/excludes in terms aggregation?

buinauskas avatar Nov 21 '23 07:11 buinauskas

sorry for the delay; I'll create PRs for each thing.

dean-shaff avatar Dec 09 '23 11:12 dean-shaff

Closing, implemented in two separate PRs.

buinauskas avatar Apr 08 '24 08:04 buinauskas