Brandon Mills

Results 108 comments of Brandon Mills

Each pattern determines its own dimensions based on what will tile ([example](https://github.com/btmills/geopattern/blob/7f7fd7916fe13b9600b9d586d73a59541e4060dd/lib/pattern.js#L245-L247)), and those should be changing based on each input string. Can you provide a few more examples of...

Are you able to put together a codesandbox that demonstrates the issue it’s causing with your layout? This was built with browser background tiling in mind, so I’m not surprised...

I saw you added a note to the readme about increasing Mocha's timeout. I'm using [the API method](http://stackoverflow.com/questions/15971167/how-to-increase-timeout-for-a-single-test-case-in-mocha) rather than the CLI parameter so that it only changes the timeout...

Good point. I saw answer given for one that [works with arrow functions](http://stackoverflow.com/a/36257128/4510592): ``` it('should not leak, () => { // Leak test }).timeout(5000); ``` Unfortunately that doesn't seem to...

I'm excited you're thinking of using this for MDN! This is the same problem we encountered when we tried to lint our own docs: unlike most published code, so many...

I suspect the cause here is the same as in #75. Before linting, the processor looks for HTML comments preceding a code block and inserts them as `/* ... */`...

Option 1 seems cleanest to me as well. We'd be able to give a very clear and actionable error message: `ecmaFeatures.globalReturn` is gone, so you should set `sourceType: "commonjs"` instead.

https://github.com/eslint/eslint/blob/9590587cef74c936ef9b7ce2d22a71e2fd0fbbc4/docs/developer-guide/working-with-rules.md#L415-L429 After taking a look at this, my opinion is that this is an issue with the Markdown source and not the CSS. That section is written as a blockquote...

I threw up a quick demo comparing ES5 vs ES6 React at [btmills/es5-react-demo](https://github.com/btmills/es5-react-demo). Realistically, the demo shouldn't\* need to many unique components. I think it would be a reasonable choice...

Though the pull request (#5108) was declined, I did end up taking the [recommendation in the feedback there](https://github.com/prettier/prettier/pull/5108#issuecomment-423278455), and I just published a fork with this change as [`@btmills/prettier`](https://www.npmjs.com/package/@btmills/prettier). (Disclaimer:...