Brandon Mills

Results 108 comments of Brandon Mills

This was auto-closed when the revert commit was merged. Re-opening since it’s still outstanding.

I'm also intrigued by this. I'd feel better if we had some data about how many rules currently don't provide schemas because by doing this, we'd also be compelling them...

@bmish having that data available would be amazing as we make the sorts of decisions you mentioned! Please share the code if you’re able because I could see us running...

That is amazing :clap: I'm also supportive and feel much better knowing that the vast majority of the ecosystem is already prepared.

I've had plenty of success using native promises (or a polyfill when native promises aren't supported). That seems like a good starting point to me; if we need more than...

:+1: to `/docs/next/` as well. Matches npm tags.

Thanks for catching this omission, @Kaltoft! I'm :+1: to fixing this. It looks like `no-underscore-dangle` doesn't check object destructuring either ([demo](https://eslint.org/play#eyJ0ZXh0IjoiLyogZXNsaW50IG5vLXVuZGVyc2NvcmUtZGFuZ2xlOiBcImVycm9yXCIgKi9cblxuY29uc3QgeyBfb2JqIH0gPSBvYmo7XG5jb25zdCBbX2Fycl0gPSBhcnI7Iiwib3B0aW9ucyI6eyJwYXJzZXJPcHRpb25zIjp7ImVjbWFWZXJzaW9uIjoibGF0ZXN0Iiwic291cmNlVHlwZSI6InNjcmlwdCIsImVjbWFGZWF0dXJlcyI6e319LCJydWxlcyI6e30sImVudiI6e319fQ==)). Would you be up for adding that as well?...

At least as of RFC72 a year ago, we chose to go dual-mode with a CJS build step for `espree`. My anecdotal impression is that the community hasn't shifted significantly...

We've added this to the roadmap, but we don't have a point person on it yet, so I've assigned eslintbot to fend of the stale bot.

The additional changes as currently described sound reasonable to me. Like others, I'd prefer to leave 2 as undefined behavior to avoid committing ourselves to a particular implementation.