Ben Sprenger comments

Results 16 comments of


                                            Ben Sprenger

Datasets does not update meta info if recording over an existing dataset

Hi @Joeclinton1, I took a quick look. It's just the dataset _card_ that is not updated, the actual dataset files seem correct. You can check this by going into the...

refactor(env): introduce explicit gym ID handling in EnvConfig/factory

Closely related to #807 (merged). This is a next step to help use LeRobot with external projects 😊 @imstevenpmwork I'm not sure who to tag who could review this, let...

refactor(env): introduce explicit gym ID handling in EnvConfig/factory

Hi @AdilZouitine , thanks for the approval! I had to rebase this commit due to the `common->src` folder structure change. Otherwise, the code is exactly the same as when you...

refactor(env): introduce explicit gym ID handling in EnvConfig/factory

Hi @AdilZouitine, any update on this? What can I do to help get this merged?

Cleanup imports

Hi Simon, Nice PR! :rocket: I saw that you tagged my PR, so I was wondering -- are you planning another way to use external configs with the training scripts,...

Cleanup imports

Thanks for the reply, sounds good! 😀

Cleanup imports

Makes sense! For the lazy imports, it might be nice if draccus itself supported `discover_packages_path` as a CLI arg (currently it has to be hardcoded in the plugin registry, I...

feat: add `remove_episodes` utility

Hey @brysonjones thanks for the review! I have made it a CLI tool and moved it to `scripts`. For the backup, I added an optional argument `backup` which can be:...

feat: add `remove_episodes` utility

@Cadene Ah, _now_ I understand the motivation for why the dataset v2 split each episode up into individual files! Indeed it's way faster to not reindex, and simply filter out...

feat: add `remove_episodes` utility

@brysonjones @liuhuanjim013 I added some flags for pushing to the hub. Let me know what you think! I also added a few lines to update the dataset card.