Brian Smith

Results 443 comments of Brian Smith

@ragul1697 let me know if you need a hand, I'm happy to apply the changes on your branch if you're okay with that. TY

> Hi @bsmth, I have made the changes for `control blocks` instead of `directives`. This will wrap up the content for Angular 18. But now, Angular 19 is released. Do...

The Learn PR has finished now (hence the conflicts) I will give you a hand fixing this

Let's merge this! Thanks a lot for your patience 🙏🏻

>This should be merged after my fleet of typo fix PRs. Already looking promising, nice work 👍🏻

Thanks all, I agree that the changes are correct, but so is the original, so it's not worth the churn. Going to close for now. If you think I've made...

For others, looks like it's planned to ship in Chrome 138: - crbug https://chromium-review.googlesource.com/c/chromium/src/+/6516297 - I2S https://groups.google.com/a/chromium.org/g/blink-dev/c/Q304_OkDAZA/m/b3Bnyab9DgAJ - chromestatus https://chromestatus.com/feature/5178394056327168

Thanks for proposing. Just to clarify, you're suggesting this would help? From: ``` ./files/en-us/web/progressive_web_apps/manifest/reference/display └── index.md ``` To: ``` ./files/en-us/web/progressive_web_apps/manifest/reference/display ├── browser │   └── index.md ├── fullscreen │   └── index.md...

Thanks Yoav, anything else to add of do you consider it done? - [x] https://github.com/mdn/content/pull/39815 I think we can close as done, but please reply if there's something else missing....