Brian Smith comments

Results 443 comments of


                                            Brian Smith

Poor choice of canvas id

Thanks for raising this one. I think that's a good idea, would you like to open a PR to fix it?

Poor choice of canvas id

Hi all, there's already a pull request open to address this: - [ ] https://github.com/mdn/content/pull/42159 You can follow along on the progress there, thanks!

docs: minor improvement to aria-describedby doc

Thanks for opening this one. @scottaohara do you want to have a look or should I ask someone from the team to review? Thanks!

The CSS `interactivity` property

Thanks for opening this one. This is currently in-progress at: - [x] https://github.com/mdn/content/pull/38692

Top Level Await examples do not have await code

Closing this one, see the linked PR for details. Thank you :)

top level await example updated with await keyword

Hi @xkeshav sorry I missed this one, I'm going through repositories to see if there's anything we overlooked. @Josh-Cena are you interested in having a look?

top level await example updated with await keyword

Thanks a lot for chiming in, Josh. @xkeshav I hope that clarifies things for you. I'm going to close this PR now but if you have some more questions of...

fx147 anchor positioning enabled by default

> Thanks @bsmth! I just edited to associate all the anchor positioning rel notes, and thought you might want to have a look. Also looking good, tnx 👍🏻

Editorial review: Add docs for private state token API

Removing the review until it's ready for an editorial, if that's OK 👍🏻

Editorial review: Add docs for private state token API

For the permissions policy directives, want to mention what `*` means? Something like: > The default allowlist for `private-state-token-issuance` is `*` (wildcard matching all origins).