content icon indicating copy to clipboard operation
content copied to clipboard

Update 1 and 4 example from /docs/Mozilla/Add-ons/WebExtensions/API/w…

Open def00111 opened this issue 7 months ago • 3 comments

…ebRequest/StreamFilter/ondata

Description

Motivation

In the first example the "*" is not needed. In the 4 example just store the string directly instead of creating an array and storing the string there.

Additional details

Related issues and pull requests

def00111 avatar May 03 '25 14:05 def00111

Preview URLs

(comment last updated: 2025-06-09 19:23:37)

github-actions[bot] avatar May 03 '25 14:05 github-actions[bot]

In the first example the "*" is not needed. In the 4 example just store the string directly instead of creating an array and storing the string there.

That doesn't look particularly meaningful, or am I missing something?

willdurand avatar May 22 '25 09:05 willdurand

@willdurand Can you look at the patch again? Is this change worth?

def00111 avatar Jun 09 '25 19:06 def00111

Thanks all, I agree that the changes are correct, but so is the original, so it's not worth the churn. Going to close for now. If you think I've made a mistake, feel free to let me know and we can take a look again. Thanks!

bsmth avatar Jul 10 '25 12:07 bsmth