Brian Smith

Results 356 comments of Brian Smith
trafficstars

> @bsmth are you championing this PR, or is @estelle doing it? I'm fine with self-assigning it to get it over the finish line. Is that okay @estelle? I'm going...

Thanks for raising this one and for the great suggestion. Here's the source CSS https://github.com/mdn/interactive-examples/blob/main/live-examples/css-examples/backgrounds-and-borders/background-clip.css#L2 >text-shadow on an interactive element prevents the "background-clip: text" property from being demonstrated I understand...

FYI I think this was already touched in https://github.com/mdn/interactive-examples/commit/f32a584cb847b5454270afc94d906de25080bedd#diff-f21bbc22811d892093185d1644b55edd90f715a2fa108e00c07735e8cc6d63fa, although this change does make some contrast improvements.

Sure thing, I think we can merge this. Thank you!

@caugner can you check https://github.com/mdn/content/pull/32802/commits/3d8a8bf7a9ab597f101c774079d9bb235b58646b to let me know if it looks okay?

I'm going to merge because I mostly updated prose so let's get it in!

Added a gh-pages deploy in https://github.com/mdn/shared-assets/pull/8 for now as a stopgap

I'm closing for the moment, I think we will revisit deployment options at a later stage

Thanks for raising this. There is a page for the pseudo-element here: https://developer.mozilla.org/en-US/docs/Web/CSS/::details-content Added in this PR: - [x] https://github.com/mdn/content/pull/37118