dom-examples icon indicating copy to clipboard operation
dom-examples copied to clipboard

Update image path to folder nested under dom-examples

Open wesgarrison opened this issue 9 months ago • 2 comments
trafficstars

Old: https://mdn.github.io/to-do-notifications/img/icon-128.png New: https://mdn.github.io/dom-examples/to-do-notifications/img/icon-128.png

wesgarrison avatar Jan 31 '25 15:01 wesgarrison

Thanks for opening this one, I think that's a good fix, there's one comment about running locally versus the preview, but I think we could even ignore my suggestion and add a note that this path should be changed in your local versions to get the icon to show. You can quickly test it with:

let local_notification = new Notification("To do list", {
  body: "Task text",
  icon: "/to-do-notifications/img/icon-128.png",
});

let gh_notification = new Notification("To do list", {
  body: "Task text",
  icon: "/dom-examples/to-do-notifications/img/icon-128.png",
});

bsmth avatar Feb 03 '25 09:02 bsmth

Hi @wesgarrison do you plan to come back to this one? There's a comment above for you to have a look at. Thanks :)

bsmth avatar May 09 '25 10:05 bsmth