Brian Smith

Results 307 comments of Brian Smith
trafficstars

Thanks all, merging 👍🏻

Hi @wbamberg I've taken another shot at it. Polling makes more sense than an `eventListener`, so I've reverted to the original here unless there's a better way of doing it...

> * user interaction is more complicated +1 on that. Out of the variations I was trying, the current one is the most self-explanatory, I think. I'm fine with the...

Hi @Josh-Cena, I've addressed your review comments, thank you. Could you have another quick look?

Not a problem, thank you! > If you believe it adequately addresses that issue (or if that issue needs to be addressed at all), feel free to self-merge. Otherwise some...

> it motivated me to contribute for the first time That's great, well done on the first contribution 🎉

Hi @howard-e, thanks a lot for the submission. There's an unaddressed comment above, do you plan to come back to this one? Thanks :)

I've made a minor update to the deprecation notice on the page in https://github.com/mdn/content/pull/23559 @dherman @lukewagner is there any progress on adding a banner on the [asm.js ](http://asmjs.org/) side?

I'm going to close this one as there's no other action I can take on this repo. It would be nice if changes could be added on asm.js, but this...

See also: https://github.com/mdn/content/pull/22285 which seems to be a duplicate