content icon indicating copy to clipboard operation
content copied to clipboard

chore(docs) minor refresh on math skills test page

Open bsmth opened this issue 3 years ago • 2 comments
trafficstars

This PR does a quick pass over the math skills test page.

The original issue is resolved, in my opinion, it's clear that this page references the reading material needed to complete the assessment. In this case, I'm doing some minor rewording to simplify.

Fixes #11058

bsmth avatar Nov 03 '22 09:11 bsmth

Preview URLs

External URLs (3)

URL: /en-US/docs/Learn/JavaScript/First_steps/Test_your_skills:_Math Title: Test your skills: Math

(this comment was updated 2022-11-18 10:51:50.900617)

github-actions[bot] avatar Nov 03 '22 09:11 github-actions[bot]

Thanks @Josh-Cena, was there anything else outstanding on this for me? I'm happy to pick it up again.

bsmth avatar Nov 10 '22 15:11 bsmth

Hi @Josh-Cena, I've addressed your review comments, thank you. Could you have another quick look?

bsmth avatar Nov 17 '22 11:11 bsmth

Not a problem, thank you!

If you believe it adequately addresses that issue (or if that issue needs to be addressed at all), feel free to self-merge. Otherwise some more context would be helpful.

I believe this page addresses the concerns in the issue, specifically this:

lack of reference to the information needed to complete the task being asked of the learner

I think it's clear from the material that readers should be applying skills learned in the previous section, so this is good to go, in my opinion.

Thanks for having a look, I will merge shortly 👍🏻

bsmth avatar Nov 18 '22 10:11 bsmth