Brigitta Sipőcz

Results 326 comments of Brigitta Sipőcz

I run into this today, but now even the workaround (https://github.com/matplotlib/matplotlib/issues/4067#issuecomment-357794003) is not working any more.

Oh, to start with I would be happy if journals would require to cite the latest reference, and not let papers being published with using a 6 years old reference...

Hmm, don't think these ended up in the sdist, but let me know if that's the case. Do you run the test suite as part of the build/install process that...

Yes they are. If there is any chance to start from the fresh sdist again after the test are run and passed, it would be a suitable workaround. OTOH, this...

@javier-ballester - the files only show up when running the tests directly with pytest as it runs them directly from the repo source tree rather than from a temp copy...

OK, so a lot of time has passed, and we moved a significant fraction of the modules to use keyword-only arguments. I would propose to try to make this change...

@mwcraig - could you please have a look at this and the linked issue?

@keflavich - I run into these same duplications while reviewing #2140, too. Do you recall any reasons why the `async_to_sync` decorator wasn't used?

@keflavich - If you would separate the function removals from the refactoring, we can ship that in 0.4.6? Or shall just add a deprecation decorator on those in 0.4.6 (though...