Thin out & refactor astroquery.alma.utils

[keflavich]

WIP to fix #1794 (I still need to do more testing and probably import cleanup).

The old finder chart code resides here: https://gist.github.com/keflavich/165b10ce09b68fb3deda50df85cf2ce8 and needs to be reworked to avoid aplpy & pyregion.

[pep8speaks]

Hello @keflavich! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file astroquery/alma/utils.py:

Line 67:9: E225 missing whitespace around operator Line 69:11: E225 missing whitespace around operator Line 82:13: E265 block comment should start with '# '

[bsipocz]

@keflavich - If you would separate the function removals from the refactoring, we can ship that in 0.4.6? Or shall just add a deprecation decorator on those in 0.4.6 (though they are not really compatible with the alma API any more, so probably there are no users out there), and we then remove them in 0.4.7?

[bsipocz]

I've rebased and fixed this up to remove the now deprecated functions.

[codecov[bot]]

Codecov Report

Merging #2331 (0ae5dad) into main (4b4af55) will increase coverage by 0.36%. The diff coverage is 10.00%.

@@            Coverage Diff             @@
##             main    #2331      +/-   ##
==========================================
+ Coverage   63.63%   63.99%   +0.36%     
==========================================
  Files         132      132              
  Lines       17092    16969     -123     
==========================================
- Hits        10876    10859      -17     
+ Misses       6216     6110     -106     

Impacted Files	Coverage Δ
astroquery/alma/utils.py	32.43% <10.00%> (+14.30%)	:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[bsipocz]

Tests are passing, so I go ahead and merge this.