Brent Shaffer

Results 194 issues of Brent Shaffer

fixes https://github.com/grpc/grpc/issues/38481

partially addresses https://github.com/guzzle/promises/issues/163

WIP - There are a lot of changes to this API and it will take time to change them all

samples

addresses https://github.com/googleapis/google-api-php-client/issues/2632 These samples are modifying a PRIVATE property using PHP reflection, which is cursed and unholy. I do not particularly want to refactor this code, so I've updated it...

Feature Request for PHP: in the phpdoc for getters and setters which correspond to an enum field, the generated class does not point to corresponding PHP enum class. The customer...

php

I followed the examples of other pages in `docs/devsite-help`, but it's quite possible I'm missing a critical aspect. I also am not sure how these will be tested. I ran...

This seems like a bug in the breaking change detector - why would changing the type to a supertype (e.g. adding another type via union types) be considered breaking? This...

testing the release check in https://github.com/googleapis/google-cloud-php/pull/8725 - [x] test check fails with less than 2 yoshi approvers - [x] test check increments the approver count as expected - [x] test...

do not merge

Similar to the Snippet Tests we have in handwritten libraries like Storage and Bigquery, we could have tests that extract the code from the `README.md` files and executes them to...