BackwardCompatibilityCheck icon indicating copy to clipboard operation
BackwardCompatibilityCheck copied to clipboard

A parameter being expanded to a union type is identified as breaking?

Open bshaffer opened this issue 3 months ago • 1 comments

This seems like a bug in the breaking change detector - why would changing the type to a supertype (e.g. adding another type via union types) be considered breaking?

Image

This is universally considered a non-breaking change AFAIK, and I cannot think of any scenario where this would break in someone's code.

It could be that this library flags ANY change to a method as breaking? But I don't think so, as that would be pretty excessive and I feel like I would have noticed that by now...

bshaffer avatar Sep 16 '25 16:09 bshaffer

Can you perhaps make a reproducer? I thought I had already fixed this one before 🤔

Ocramius avatar Sep 16 '25 18:09 Ocramius