google-cloud-php icon indicating copy to clipboard operation
google-cloud-php copied to clipboard

DO NOT MERGE: Testing release improvements

Open bshaffer opened this issue 1 month ago • 0 comments

testing the release check in https://github.com/googleapis/google-cloud-php/pull/8725

  • [x] test check fails with less than 2 yoshi approvers
  • [x] test check increments the approver count as expected
  • [x] test check triggers when approver count changes
  • [x] test check triggers when PR description is changed
  • [x] test check skips when M*JOR_VERSION_ALLOWED= does not exist in PR body
  • [x] test check passes with M*JOR_VERSION_ALLOWED= and 2 yoshi approvers

The review triggered but the old failing review is still there

Screenshot 2025-12-05 at 12 02 40 PM

MAJOR_VERSION_ALLOWED=foo

bshaffer avatar Dec 05 '25 16:12 bshaffer