Brent Shaffer

Results 407 comments of Brent Shaffer

This all sounds accurate, thank you for taking the time to type this out. Although I'm not sure about point 2. When are the previous tokens used to initialize the...

Hello! Thank you for your suggestion. We can add `format=full` to the `GCECredentials` request to get the ID Token, but I am not sure how the extra payload would be...

> why does the PR still mark their tests as expected to be reported (and in-fact required). Because this is managed in the GitHub repo settings (the yaml file syncs...

I've added the `Do Not Merge` label because we are going to postpone dropping support for PHP 8.0 until May. We will drop support for PHP 7.4 on Feb 29th....

Hello @chris-lee-lb ! Thank you for filing this issue. I see the problem in the first point, but in the second point, if you retrieve a cache item successfully (e.g....

How could this possibly be working as designed for the symfony file cache? Why would a retrieved item be given unlimited expiry by default? I'll need to consult the PSR...

To me that seems to be referring to a new item, and not one that has been previously pulled from the cache. It seems odd to me to not be...

@mihaileu we are sorry to hear this caused you and your customers difficulty. Please update your library to [v6.10.1](https://github.com/firebase/php-jwt/releases/tag/v6.10.1), and this should now be fixed.

@bojanpejic it would be a _new_ major version of the library we haven't released yet, where we would remove these `autoload.php` files.

Just so we are clear, @bojanpejic and @umpirsky and anyone else following this PR... If you update your code to use the new namespaces (e.g. `Google\Client` and `Google\Service\ServiceName`), these hits...