Benjamin Sergeant

Results 110 comments of Benjamin Sergeant

Thanks for taking a look, you're making some good points. I have a project where I still have a very tiny makefile in the top folder which takes care of...

I found something interesting where a build fail through cmake, but not with the regular make build. (the xenial warning config). The other outstanding thing I'm looking at is making...

I updated the PR @Spacelm > On Jan 11, 2021, at 1:19 AM, SpaceIm wrote: > > > @SpaceIm commented on this pull request. > > In CMakeLists.txt : >...

``` $ mkdir build $ cd build $ cmake -DDEFLATE_BUILD_TEST_PROGRAMS=ON .. $ make ... $ make test Running tests... Test project /Users/benjaminsergeant/src/foss/github/libdeflate/build Start 1: test_checksums 1/6 Test #1: test_checksums ......................

@ebiggers I've changed the PR to be purely additive, and not conflict with any existing makefiles or scripts. I know you made your point about wanting to have a single...

Thanks Roger, I’ll try to incorporate your feedback in the PR. 1. I don’t think that the library depends on zlib, just the tests and not even sure 2. Getting...

I think there should be a mini transition period where both makefile and cmakefiles exists, so that we can know that the new system actually works. I'm still very interested...

Hi there, chiming in since I'm using python with asyncio too. Historically I used this library, but then moved to aioredis because I needed redis stream support, which wasn't supported...

I'm also getting that error + I'm using the same websocket library (and python 3.7.3 on alpine linux)

Looks like the problem is gone (I also switched to python 3.7.4 btw). Thanks for the hint @jlaine !